Limit spec-defined option values #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
added
normative
aphillips
requested changes
Nov 10, 2024
|
I think this is going in the wrong direction, because it prevents us in the future from having function options with option values that are free-form. See my other comments. |
aphillips
reviewed
Nov 12, 2024
macchiati
reviewed
Nov 13, 2024
aphillips
reviewed
Nov 14, 2024
aphillips
requested changes
Nov 14, 2024
Co-authored-by: Mark Davis <[email protected]>
eemeli
commented
Nov 14, 2024
aphillips
approved these changes
Nov 14, 2024
macchiati
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
Explicitly reserves the
u:namespace, which was previously only mentioned in the syntax.Limits spec option values to
a-zA-Z0-9,-and.. The.is not currently used, but is needed to allow for e.g.2.5as a future reserved value.Replaces two "MUST NOT" restrictions elsewhere with "will not" to match the style of the rest of the text.