-
-
Notifications
You must be signed in to change notification settings - Fork 35
Always apply isolation when u:dir is set
#942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,19 +56,22 @@ | |
| }, | ||
| { | ||
| "src": "hello {world :string u:dir=ltr u:id=foo}", | ||
| "exp": "hello world", | ||
| "exp": "hello \u2066world\u2069", | ||
| "expParts": [ | ||
| { | ||
| "type": "literal", | ||
| "value": "hello " | ||
| }, | ||
| { "type": "bidiIsolation", "value": "\u2066" }, | ||
| { | ||
| "type": "string", | ||
| "source": "|world|", | ||
| "dir": "ltr", | ||
| "id": "foo", | ||
| "value": "world" | ||
| } | ||
| }, | ||
| { "type": "bidiIsolation", "value": "\u2069" } | ||
|
|
||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -102,6 +105,25 @@ | |
| { "type": "bidiIsolation", "value": "\u2069" } | ||
| ] | ||
| }, | ||
| { | ||
| "src": ".local $world = {world :string u:dir=ltr u:id=foo} {{hello {$world}}}", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is intended as the transitivity text, I think? Should we have one with mulitple There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Eh, not sure if it's necessary. I think the important part is making sure that moving the option from the placeholder to a declaration works. |
||
| "exp": "hello \u2066world\u2069", | ||
| "expParts": [ | ||
| { | ||
| "type": "literal", | ||
| "value": "hello " | ||
| }, | ||
| { "type": "bidiIsolation", "value": "\u2066" }, | ||
| { | ||
| "type": "string", | ||
| "source": "|world|", | ||
| "dir": "ltr", | ||
| "id": "foo", | ||
| "value": "world" | ||
| }, | ||
| { "type": "bidiIsolation", "value": "\u2069" } | ||
| ] | ||
| }, | ||
| { | ||
| "locale": "ar", | ||
| "src": "أهلاً {بالعالم :string u:dir=rtl}", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.