Internationalize the :math example
#945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's not embarrass ourselves, eh? The trailing selector should use the keyword `one` instead of the exact match `1`, in part because other languages need to explode (or contract, e.g. in languages such as `ja` or `zh`) the matrix.
aphillips
added
functions
aphillips
requested review from
catamorphism,
echeran,
eemeli,
macchiati,
mihnita and
mradbourne
macchiati
approved these changes
Nov 18, 2024
eemeli
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's not embarrass ourselves, eh?
The trailing selector should use the keyword
oneinstead of the exact match1, in part because other languages need to explode (or contract, e.g. in languages such asjaorzh) the matrix.