Skip to content

In bidi default strategy, make steps consistent with each other #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 16, 2024
Merged

In bidi default strategy, make steps consistent with each other #969

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6e8513a
In bidi default strategy, make steps consistent with each other
catamorphism Dec 6, 2024
39e9056
Don't replace entire formatted output
catamorphism Dec 6, 2024
c69013d
Reformulate the default bidi strategy as a function
catamorphism Dec 9, 2024
386fa2f
Rewrite imperatively
catamorphism Dec 11, 2024
019a29f
Add last line (emit output)
catamorphism Dec 11, 2024
f42453c
Fix formatting
catamorphism Dec 11, 2024
4c918ac
Fix formatting harder
catamorphism Dec 11, 2024
7c5bf61
Fix formatting again
catamorphism Dec 11, 2024
53aa0fb
Remove erroneously-added file
catamorphism Dec 11, 2024
daa95ad
Update spec/formatting.md
catamorphism Dec 11, 2024
0b2f7a3
Fix indentation
catamorphism Dec 11, 2024
e9afb9d
Apply suggestions from Eemeli
catamorphism Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/formatting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,9 +942,9 @@ The _Default Bidi Strategy_ is defined as follows:
True if the `u:dir` _option_ of the _resolved value_ of `exp` has a value other than `'inherit'`,
or False otherwise.
1. If `dir` is `'LTR'`:
1. If `msgdir` is `'LTR'` in the formatted output
1. If `msgdir` is `'LTR'`
and `isolate` is False,
let `fmt` be itself
append `fmt` to the formatted output.
Copy link
Member

@aphillips aphillips Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other steps don't do append. They talk about what fmt contains (e.g. "prefix fmt with...")

The change we should be making should actually be earlier. Something like:

  1. For each expression exp in pattern:
    i. Let fmt be the formatted string representation of the resolved value of exp to be appended to the formatted output.

1. Else, in the formatted output,
prefix `fmt` with U+2066 LEFT-TO-RIGHT ISOLATE
and postfix it with U+2069 POP DIRECTIONAL ISOLATE.
Expand Down