Drop selection from :currency and :unit #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
approved these changes
Jan 28, 2025
mihnita
approved these changes
Feb 2, 2025
eemeli
added a commit
that referenced
this pull request
Feb 10, 2025
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Mar 2, 2025
XM5jDcsHTyGJtQqlCi
added a commit
to XM5jDcsHTyGJtQqlCi/messageformat
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed today, we should leave out selection from
:currencyand:unitfor now, as it's not clear that data is available to select correct plural values for them. For example, consider how the English phrase "$3 is your total price" refers to the currency value in the singular.If/once selection on these values is better defined, we should consider adding support for that in MF2.
Where necessary, plural selection on the numerical values of currencies and unitized values is still possible via
:numberand:integer, which do support selection.