Skip to content

Conversation

@oscarotero
Copy link

@oscarotero oscarotero commented Aug 11, 2025

This PR upgrades Lume to the last version.

  • Esbuild plugin now compiles the code correctly.
  • I don't use Tailwind so I don't know how to upgrade some configuration to v4. I did my best but I have no idea how the animation works and I got errors for using @apply inside @keywords (specifically pulse-bg-blue). So I removed this animation. Probably you know how to bring it back.
  • Most changes are caused by the deno fmt command. edit: I reverted this change for clarity

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the formatting changes seems rather unrelated to a dependency update. That should probably be done in a separate PR, if it's required at all.

This reverts commit 83404a3.
@oscarotero
Copy link
Author

@eemeli Fair enough
I just reverted the formatting commit and now it's easier to review the real changes.

@oscarotero oscarotero requested a review from eemeli September 1, 2025 13:37
@eemeli
Copy link
Collaborator

eemeli commented Sep 1, 2025

I don't have write access or a good understanding of the stack used here, so this probably needs a review from @lucacasonato rather than me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants