Merged
Conversation
markusicu
reviewed
Mar 18, 2025
Member
markusicu
left a comment
markusicu
left a comment
There was a problem hiding this comment.
I have not looked at the whole thing again now, and I think I won't.
- I have looked at your replies that I hadn't seen before
- I have looked at your changes other than rebuilding the branch and satisfying CI
- I caught up on emails that I hadn't read before
- I have read your updated readme
Here I have a couple of small comments on recent changes. After this I am inclined to unpack a big rubber stamp :-)
unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java
Outdated
Show resolved
Hide resolved
Closed
markusicu
approved these changes
Mar 21, 2025
Member
markusicu
left a comment
markusicu
left a comment
There was a problem hiding this comment.
After this I am inclined to unpack a big rubber stamp :-)
... and here is... the big rubber stamp.
Thank you!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.