Don’t invert twice on comparison queries#1057
Merged
eggrobin merged 7 commits intounicode-org:mainfrom Mar 12, 2025
Merged
Conversation
…s, align identity queries with the draft
markusicu
reviewed
Mar 11, 2025
UnicodeJsps/src/main/java/org/unicode/jsp/UnicodeSetUtilities.java
Outdated
Show resolved
Hide resolved
UnicodeJsps/src/main/java/org/unicode/jsp/UnicodeSetUtilities.java
Outdated
Show resolved
Hide resolved
markusicu
approved these changes
Mar 12, 2025
Member
|
Looking forward to having this in the JSPs too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\p{Uppercase≠@Changes_When_Lowercased@} is currently equal to \p{Uppercase=@Changes_When_Lowercased@} rather than \P{Uppercase=@Changes_When_Lowercased@}, because it is re-inverted before it is returned.
Also added support for null queries and aligned identity queries with the working draft (
code pointlike in@missinglines rather thancp, and LM3 matching), and brought LM3 matching up to date with Unicode 6.0, stripping leadingis(see also https://www.unicode.org/reports/tr44/tr44-6.html#UAX44-LM3, the proposed update https://www.unicode.org/reports/tr44/tr44-5.html#UAX44-LM3, UTC-120-A106, and L2/09-248).