Fix versioned GC groupings in the JSPs#1058
Merged
eggrobin merged 7 commits intounicode-org:mainfrom Mar 12, 2025
Merged
Conversation
eggrobin
changed the title
Member
|
What's a "flig"? ;-) |
eggrobin
force-pushed
the
versioned-gc-groupings
branch
from
905d39b to
bbb7f5a
Compare
Member
Author
It’s something I write on the commind line to enible the test. |
markusicu
previously approved these changes
Mar 12, 2025
UnicodeJsps/src/main/java/org/unicode/jsp/UnicodeSetUtilities.java
Outdated
Show resolved
Hide resolved
markusicu
approved these changes
Mar 12, 2025
Member
markusicu
left a comment
markusicu
left a comment
There was a problem hiding this comment.
much better, thanks! :-)
I guess at some point we will want to remove the hardcoded lists from MakeUnicodeFiles.java as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation used getSet with a non-null UnicodeSet parameter, which updated the parameter according to the most recent version of the UCD when using incremental properties.
Unfortunately incremental property storage isn’t nicely testable because turning it on messes with static (and even file) caches, and we cannot turn it on by default because of #716.
Also handle the alias Combining_Mark for the gc=M grouping. Apparently it was added in 6.1, see UTC-126-C1.
unicodetools/unicodetools/data/ucd/6.1.0-Update/PropertyValueAliases.txt
Line 554 in d29babc
unicodetools/unicodetools/data/ucd/6.0.0-Update/PropertyValueAliases.txt
Line 508 in d29babc