LM2 Name and Name_Alias matching#1059
Merged
eggrobin merged 15 commits intounicode-org:mainfrom Mar 13, 2025
Merged
Conversation
…s, align identity queries with the draft
…ans casser des œufs)
Member
|
It looks like some of your commits are from the previous PR. Do you need to rebase? |
Member
Author
Yes, I worked on the two in parallel and merged.
I’d rather not. I don’t think the individual commits are useful to the reviewer here anyway, probably best to just look at https://github.com/unicode-org/unicodetools/pull/1059/files. |
markusicu
reviewed
Mar 13, 2025
| checkSetsEqual("\\p{Name=twoemdash}", "⸺"); | ||
| checkSetsEqual("\\p{Name=SeeNoEvil_Monkey}", "🙈"); | ||
| checkSetsEqual("\\p{Name=BALLET S-H-O-E-S}", "🩰"); | ||
| checkSetsEqual("[\\p{Name=LATIN SMALL LIGATURE O-E}uf]", "[œuf]"); |
unicodetools/src/main/java/org/unicode/props/IndexUnicodeProperties.java
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/props/UnicodeProperty.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/props/UnicodeProperty.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/props/UnicodeProperty.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/props/UnicodeProperty.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
markusicu
approved these changes
Mar 13, 2025
Member
|
nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And treat Name_Alias as a Name alias in the JSPs.