Skip to content

Fix [:C:] getting interpreted as the entire code space #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eggrobin merged 3 commits into from
Mar 27, 2025
Merged

Fix [:C:] getting interpreted as the entire code space #1076

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78cd8d3
Other=ISO_Comment
eggrobin Mar 26, 2025
23eace7
c
eggrobin Mar 26, 2025
b470e08
spots
eggrobin Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions unicodetools/src/main/java/org/unicode/props/UnicodeProperty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,13 @@ private class MyXSymbolTable extends UnicodeSet.XSymbolTable {
@Override
public boolean applyPropertyAlias(
String propertyName, String propertyValue, UnicodeSet result) {
if ((propertyName.equals("C") || propertyName.equals("c")) && propertyValue.isEmpty()) {
// C matches isc=ISO_Comment, and we are not able to distinguish
// \p{C} (=\p{General_Category=Other}) from \p{C=} (=\p{ISO_Comment=}) here.
// Fall back to ICU, since this symbol table does not implement GC groupings.
// TODO(egg): This symbol table needs to go, see #1073, #1074.
return false;
}
if (false) System.out.println(propertyName + "=" + propertyValue);
UnicodeProperty prop = getProperty(propertyName);
if (prop == null) return false;
Expand Down
Loading