-
-
Notifications
You must be signed in to change notification settings - Fork 61
UAE Dirham sign #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAE Dirham sign #1190
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please revert files that only have time stamp changes |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1603,6 +1603,7 @@ direct sum 2295 | |
| Directional Format Characters 202A | ||
| DIRECTIONAL FORMATTING, POP 202C | ||
| DIRECTIONAL ISOLATE, POP 2069 | ||
| DIRHAM SIGN, UAE 20C3 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Ken-Whistler usually adds things into the Index late in a release. Ken, do you want this here in the pending-for-18 pull request? |
||
| DISCONTINUOUS UNDERLINE SYMBOL 2382 | ||
| discretionary hyphen 00AD | ||
| disjunction 2228 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # LineBreak-17.0.0.txt | ||
| # Date: 2025-07-29, 13:52:18 GMT | ||
| # LineBreak-18.0.0.txt | ||
| # Date: 2025-08-05, 22:20:00 GMT | ||
| # © 2025 Unicode®, Inc. | ||
| # Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the U.S. and other countries. | ||
| # For terms of use and license, see https://www.unicode.org/terms_of_use.html | ||
|
|
@@ -971,7 +971,9 @@ | |
| 20BF ; PR # Sc BITCOIN SIGN | ||
| 20C0 ; PO # Sc SOM SIGN | ||
| 20C1 ; PR # Sc SAUDI RIYAL SIGN | ||
| 20C2..20CF ; PR # Cn [14] <reserved-20C2>..<reserved-20CF> | ||
| 20C2 ; PR # Cn <reserved-20C2> | ||
| 20C3 ; AL # Sc UAE DIRHAM SIGN | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably not lb=AL.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, I think I had written something about PO vs. PR in discussion of the Riyal, let me see if I can find that…
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah yes, in https://github.com/unicode-org/sah/issues/619, published in L2/25-087:
So the question is whether it would be prefix in a CJK context.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comparing Saudi (PR) and UAE websites, it looks like PR is the appropriate value. |
||
| 20C4..20CF ; PR # Cn [12] <reserved-20C4>..<reserved-20CF> | ||
| 20D0..20DC ; CM # Mn [13] COMBINING LEFT HARPOON ABOVE..COMBINING FOUR DOTS ABOVE | ||
| 20DD..20E0 ; CM # Me [4] COMBINING ENCLOSING CIRCLE..COMBINING ENCLOSING CIRCLE BACKSLASH | ||
| 20E1 ; CM # Mn COMBINING LEFT RIGHT ARROW ABOVE | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13711,6 +13711,8 @@ | |
| * Kyrgyzstan | ||
| 20C1 SAUDI RIYAL SIGN | ||
| * Saudi Arabia | ||
| 20C3 UAE DIRHAM SIGN | ||
| * United Arab Emirates | ||
|
Comment on lines
+13714
to
+13715
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ken generates the NamesList from other sources, and likes to add change comments at the top. I assume that he would prefer not to add this in this kind of PR.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, NamesList should not be touched by these PRs.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with Robin. Don't touch NamesList.txt directly. (And don't deal with Index.txt, either -- updating that is outside the context of establishing the properties.) |
||
| @@ 20D0 Combining Diacritical Marks for Symbols 20FF | ||
| @ Combining diacritical marks for symbols | ||
| 20D0 COMBINING LEFT HARPOON ABOVE | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Ignoring Name Age LineBreak: | ||
|
|
||
| # U+20C3 is the UAE Dirham sign, similar to other currency symbols: | ||
| # TODO: current comparison is probably wrong because the line break properties differ: | ||
| # PO for SAUDI RIYAL SIGN | ||
| # AL for UAE DIRHAM SIGN | ||
| Propertywise [\N{SAUDI RIYAL SIGN-20C1} | ||
| \N{UAE DIRHAM SIGN-20C3}] AreAlike | ||
|
|
||
| end Ignoring; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DerivedAge (like the Derived files generally) is never hand-edited, only regenerated as described in https://github.com/unicode-org/unicodetools/blob/main/docs/pipeline.md#regenerate-ucd.
This means that it will falsely say that this file is targeted for 17.0 (because we don’t have an 18.0 yet). That is OK, it will get regenerated to 18 once we have an 18 and the merge/regenerate commands get run on that PR.
The CI is supposed to put up a warning saying that this does not actually target 17 (otherwise some people in the public get false hopes looking at the diffs), but it does not know about 18, only about provisional assignment. I will fix the CI.