Conversation
954f0d6 to
a1199e6
Compare
|
@eggrobin Apparently this is my first attempt at adding characters rather than simply reviewing. Do I need to manually edit the UCD files or is there a more streamlined process? |
|
I tried adding the new characters to dev/UnicodeData.txt and running MakeUnicodeFiles.java with |
The process is described here (here I expect it would basically mean add to UnicodeData, add to Scripts, and as you found, regenerate UCD with MakeUnicodeFiles). |
What changes? (Remember to clear the stupid BIN cache which never works, see #1125. I will go right ahead and fix this issue, this is utterly ridiculous.) |
Some characters ended up with the wrong age, e.g. the ARCHAIC SHRII characters had 16.0
That was my problem! Will push up something shortly. |
baf7bca to
b502bd6
Compare
|
Where did the Derived files go? Whoops… |
b502bd6 to
29f7fea
Compare
|
So, rather than fixing all of the dumb merge conflicts in extracted/ I deleted the files, assuming they would be entirely rebuilt. Let that be a lesson, I suppose. |
29f7fea to
a1b326c
Compare
|
For some reason the extracted/ files still don’t have the new characters. Help me @eggrobin, you’re my only hope. |
|
I ran the following commands (Windows, in-source; paths and syntactic details will probably differ for you). mvn compile exec:java '-Dexec.mainClass="org.unicode.text.UCD.MakeUnicodeFiles"' '-Dexec.args="-c"' -am -pl unicodetools "-DCLDR_DIR=..\cldr\" "-DUNICODETOOLS_GEN_DIR=Generated" "-DUNICODETOOLS_REPO_DIR=."
git commit -am "Regenerate UCD"
n compile exec:java '-Dexec.mainClass="org.unicode.tools.GenerateLinkData"' -am -pl unicodetools "-DCLDR_DIR=..\cldr\" "-DUNICODETOOLS_GEN_DIR=Generated" "-DUNICODETOOLS_REPO_DIR=."
git add *LinkTerm.txt
git commit -m "And regenerate LinkTerm too"I need to make MakeUnicodeFiles regenerate link data so I don’t need to have those last three lines, this is getting annoying. P.-S.: GitHub actions seems to be in a bad mood and isn’t giving us runners to run the tests. |
They’re probably just upset with all the dumb stuff I made them check. |
|
GitHub Actions stopped sulking and complained about a couple of things. Hopefully fixed now. |
[185-C31] Consensus: Accept nine (9) new emoji characters with the following character names, based on Section 1 of document L2/25-230, for Unicode Version 18.0:
[186-C2] Consensus: Change the character approved for Unicode Version 18.0 at U+1FAEB from FACE WITH SQUINTING EYES to CRACKING FACE, based on Section 1 of document L2/26-008 and L2/26-048.
I tried to keep track of the steps I took but as always I start getting a little woozy at some point such that some of the later steps may be slightly out of order. The steps themselves are below but basically what it amounts to is I keep re-running GenerateEmoji.java until it stops throwing errors and the data files themselves stop changing, meaning they have been completely bootstrapped.
Status=Draft CandidateE0.0