Regenerate linkification data in MakeUnicodeFiles#1286
Regenerate linkification data in MakeUnicodeFiles#1286eggrobin merged 6 commits intounicode-org:mainfrom
Conversation
…riter to avoid a collision with another TempPrintWriter
… UCD-wide copyright date for that.
|
spotless looks unhappy |
| writePropHeader(out.tempPrintWriter, HEADER_PROP_TERM, "LinkTerm", "Link_Term", "Hard"); | ||
| for (LinkTermination propValue : LinkTermination.NON_MISSING) { | ||
| bf.showSetNames(out, propValue.base); | ||
| bf.showSetNames(out.tempPrintWriter, propValue.base); |
There was a problem hiding this comment.
When do we use out.tempPrintWriter vs. just out?
| # Date: 2026-01-31, 12:27:25 GMT | ||
| # © 2026 Unicode®, Inc. | ||
| # Date: 2026-02-03, 13:35:49 GMT | ||
| # © 2025 Unicode®, Inc. |
There was a problem hiding this comment.
We should definitely write 2026 now.
There was a problem hiding this comment.
Yes, but we should make this change consistently and globally by updating MakeUnicodeFiles.txt. This will rewrite the whole UCD. Let’s do that in another PR.
|
|
||
| public static void main(String[] args) throws IOException { | ||
| generatePropertyData(); | ||
| System.out.println("TLDs=\t" + Joiner.on(' ').join(LinkUtilities.TLDS)); |
There was a problem hiding this comment.
I haven’t the faintest idea, this print statement was at the beginning of generatePropertyData and wasn’t part of the generation of any of the three files, so I lifted it here to preserve the behaviour of this tool.
I guess it has something to do with top level domains ?
|
now you have a merge conflict... |
| String filename, | ||
| String testName, | ||
| String copyrightYear) { | ||
| out.println(simpleFormatter.format(filename, dt.format(now), copyrightYear, testName)); |
There was a problem hiding this comment.
curious / probably for later: are dt.format(now) and copyrightYear used for the same output?
There was a problem hiding this comment.
dt.format(now) is for the Date: line; that one is actually the time of regeneration, but ignored for diffing.
copyrightYear is not ignored for diffing, so when using MakeUnicodeFiles it is from MakeUnicodeFiles.txt so that we don’t break on the 1st of January.
(Of course the emoji do break on the 1st of January, see #1273. I should fix that, timebombs in CI are annoying.)
macchiati
left a comment
macchiati
left a comment
There was a problem hiding this comment.
Thanks for all the cleanup and integration!
3 participants
And only regenerate it if it changes.