Correct confusable pair for U+1D9F from U+1D4B to U+1D4C#1307
Merged
Conversation
roozbehp
force-pushed
the
roozbehp-open-e
branch
from
8f1e3a5 to
137b654
Compare
josh-hadley
previously approved these changes
Feb 20, 2026
Member
|
The changes lgtm, but there used to be one failing CI check for security invariants (because we don't have Identifier_Type values yet for new characters), and now we have two. Please take a look. |
See unicode-org/properties#500 This needs a temporary patch to the code to skip the suppression of the new pair.
roozbehp
force-pushed
the
roozbehp-open-e
branch
from
137b654 to
a688337
Compare
Contributor
Author
The two checks are reporting the exact same errors. I don't know why there's two of them now, but I'm sure there's no new actual issues introduced by this. |
Contributor
Author
|
Please rubber stamp, as I needed to rebase on top of #1308 |
markusicu
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/unicode-org/properties/issues/500
This needs a temporary patch to the code to skip the suppression of the new pair.