Skip to content

Fixes for debug formatting #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

Fixes for debug formatting #22

merged 1 commit into from
Aug 14, 2025

Conversation

dcsommer
Copy link
Contributor

  • Debug now prints full values for the internal representation, which is more helpful when combined with a hex or binary debug printing mode.
  • Display now properly renders all the scripts with " + " separators.

@Manishearth
Copy link
Member

I'm opposed to retargeting the Debug impl. Most of the time someone using this crate cares will need one so they can slap derive(Debug) on a struct containing it, and as such clients of this crate should never have to care about the internal implementation. A debug impl that exposes the internal bitfields is primarily useful for people working on this crate itself, which is not a great tradeoff: if I'm working on this crete I can always temporarily tweak its Debug impl if I need.

@dcsommer
Fixes for debug formatting
d4936cb 
`Debug` and `Display` now properly print all the scripts with " + " seperators.
@dcsommer
Copy link
Contributor Author

Fair enough. Limited the PR to bug fix for + separators in Debug/Display.

@Manishearth Manishearth merged commit a5f747b into unicode-rs:master Aug 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcsommer @Manishearth