Add method to return ISO15924 tag as u32
#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
iso15924-tag
branch
from
2eb5038 to
3447343
Compare
Manishearth
approved these changes
Aug 15, 2025
Manishearth
reviewed
Aug 15, 2025
src/lib.rs
Outdated
| @@ -38,6 +38,12 @@ impl Script { | |||
| Self::inner_from_short_name(input) | |||
| } | |||
|
|
|||
| /// The 4-byte iso15924 tag as a `u32` | |||
There was a problem hiding this comment.
nit: document as big-endian?
There was a problem hiding this comment.
nit: document as big-endian?
Might be a stupid question, but doesn't u32::from_be_bytes convert to a native endian u32?
There was a problem hiding this comment.
Hmm... yeah I think so. Perhaps this API ought return [u8; 4] to avoid ambiguity.
Signed-off-by: Nico Burns <[email protected]>
Manishearth
approved these changes
Aug 15, 2025
|
@Manishearth Any chance of a release with these changes? |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Aug 18, 2025
…t for harfbuzz (#38704) Replaces a big match statement with a call to `unicode_script`'s `Script::short_name` method which has the same big match statement. We special case `Script::Unknown` because the `short_name` method returns empty string for that variant, but harfbuzz represents it with `Zzzz`. EDIT: `Zzzz` seems to be in the spec so I've sent a PR to `unicode_script` to use it: unicode-rs/unicode-script#23 EDIT: And unicode-rs/unicode-script#24 which would allow us to remove this method entirely. Signed-off-by: Nico Burns <[email protected]>
PotatoCP
pushed a commit
to PotatoCP/servo
that referenced
this pull request
Aug 20, 2025
…t for harfbuzz (servo#38704) Replaces a big match statement with a call to `unicode_script`'s `Script::short_name` method which has the same big match statement. We special case `Script::Unknown` because the `short_name` method returns empty string for that variant, but harfbuzz represents it with `Zzzz`. EDIT: `Zzzz` seems to be in the spec so I've sent a PR to `unicode_script` to use it: unicode-rs/unicode-script#23 EDIT: And unicode-rs/unicode-script#24 which would allow us to remove this method entirely. Signed-off-by: Nico Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
short_nameis always 4 ascii bytes, so it's convenient to be able to access it as au32.