Introduce Lua 5.4 application to catalog-core#60
Introduce Lua 5.4 application to catalog-core#60Dana-Maria04 wants to merge 1 commit intounikraft:mainfrom
Conversation
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Use a single commit. Squash the two current commits into a single one.
|
All feedback applied ! |
Dana-Maria04
force-pushed
the
add-lua-app
branch
3 times, most recently
from
53372c8 to
2ee68a8
Compare
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Update your author and signed-off-by name to be properly written, i.e. use Dana Caruntu <caruntudana@yahoo.com> instead of Dana Caruntu <caruntudana@yahoo.com>.
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Add instructions on building the filesystem.
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Add instructions on building the filesystem.
Dana-Maria04
force-pushed
the
add-lua-app
branch
2 times, most recently
from
c9cd4c7 to
834751b
Compare
Dana-Maria04
force-pushed
the
add-lua-app
branch
5 times, most recently
from
9f7ecd4 to
c98432c
Compare
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Update the author (
git config --global user.name 'Dana Caruntu'
git config --global user.email 'caruntudana@yahoo.com'
git commit --amend --reset-author
You have two signed-off lines. Leave only one.
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
There is no rootfs/ directory (with the helloworld.lua file inside of it).
Dana-Maria04
force-pushed
the
add-lua-app
branch
2 times, most recently
from
e41a383 to
ea08759
Compare
Dana-Maria04
changed the title
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Update your commit message to not mention the .gitignore update in the message description. Do add a reference to the .gitignore file being added. Take inspiration from the commit message introducing python3-hello. See here.
Add Lua 5.4 application Add `lua/` directory: - `Config.uk`: application configuration - `Makefile`: for building the application - `Makefile.uk`: empty placeholder required by the build system - `README.md`: instructions - `setup.sh`: script to initialize and populate the root filesystem - `rootfs/helloworld.lua`: the Lua Hello program - `fc.x86_64.json` / `fc.arm64.json`: Firecracker configurations for x86_64 and ARM64 - `xen.x86_64.cfg` / `xen.arm64.cfg`: Xen configurations for x86_64 and ARM64 - `.gitignore`: ignore generated files Signed-off-by: Dana Caruntu <caruntudana@yahoo.com>
2 participants
What’s included
Unikraft-specific configuration and build scripts for the Lua unikernel
Top-level wrappers to bootstrap the build (
make all,make distclean, etc.)A minimal Lua script that prints “Hello from Lua!”
How to configure, build and run (QEMU/Xen) the Lua unikernel
fc.x86_64.json,fc.arm64.jsonfor functional testsxen.x86_64.cfg,xen.arm64.cfgfor Xen targets