fix: Several fixes and features for rootfs file systems#2676
Merged
nderjung merged 7 commits intounikraft:stagingfrom Mar 4, 2026
Merged
fix: Several fixes and features for rootfs file systems#2676nderjung merged 7 commits intounikraft:stagingfrom
nderjung merged 7 commits intounikraft:stagingfrom
Conversation
Without this transformation would fail silently as it would be identified as a tar file. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Do not use special cpio writer if the file is already packed. We can use a simple copy. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/fs-fixes
branch
from
64ca1a1 to
954c329
Compare
nderjung
reviewed
Mar 3, 2026
nderjung
reviewed
Mar 3, 2026
Member
nderjung
left a comment
nderjung
left a comment
There was a problem hiding this comment.
This looks good to me, just one comment about the name of a method.
I've also tested locally with a couple of scenarios and it works for me 👍 thanks!
Will merge after the rename :)
Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
This value will be set to the empty string from the CLI if it's not explicitly set with `--rootfs-type`. This essentially results in overwriting the pre-populated default cpio type with an empty fs type. This then just silently skips the build in older versions of kraft, or causes a weirdly strange internal error on staging. Signed-off-by: Justin Chadwell <justin@unikraft.com>
Debugging without these is an absolute PITA. Signed-off-by: Justin Chadwell <justin@unikraft.com>
craciunoiuc
force-pushed
the
craciunoiuc/fs-fixes
branch
from
954c329 to
888fab5
Compare
nderjung
approved these changes
Mar 4, 2026
Member
nderjung
left a comment
nderjung
left a comment
There was a problem hiding this comment.
Thanks!
Reviewed-by: Alexander Jung alex@unikraft.com
Approved-by: Alexander Jung alex@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
Description of changes
The fixes and their reasonings are:
erofs->cpiofail was mentioned but somehow missing, readd iterofsfiles was possible, butcpiofiles not because of the custom writer; use a direct onefiletype was hiding, use it to copy any file as initrd, not just cpio/erofs (notice files on disk will have.fileextension)unknowntype to be used when specifying files but you want autodetect the type fully. A bit useless but might be turned useful later if we want to do even more detectionCloses: #2675