Fix issue 2117 - #2160
Open
m-farooqui wants to merge 4 commits into
Open
Fix issue 2117#2160m-farooqui wants to merge 4 commits into
m-farooqui wants to merge 4 commits into
Conversation
Signed-off-by: m-farooqui <farooqui.awais@gmail.com>
… synthesis strategies - Add installation note to data_synthesis_strategies.md - Clarifies that pip install 'pandera[strategies]' is required - Resolves confusion between hypotheses vs strategies extras - Matches format used in hypothesis.md page This Resolves Issue#1649 Signed-off-by: m-farooqui <farooqui.awais@gmail.com>
- Fix incorrect comment in fn_mutate_inplace example - Add warning about @check_types limitation with in-place modifications - Add working example demonstrating proper @check_types behavior - Provide manual validation workaround for the limitation The @check_types decorator may not catch schema violations when DataFrames are modified in-place after being validated with .pipe(). This happens because in-place operations don't invalidate the attached schema, causing @check_types to skip re-validation. Resolves unionai-oss#2117 Signed-off-by: m-farooqui <farooqui.awais@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2160 +/- ##
==========================================
- Coverage 94.28% 86.37% -7.91%
==========================================
Files 91 136 +45
Lines 7013 10822 +3809
==========================================
+ Hits 6612 9348 +2736
- Misses 401 1474 +1073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Maintainer triage: this fixes docs (issue #2117, mypy/strategies documentation around in-place mutation) that appear to have already been rewritten on `main` with a correct explanation — this branch is 360+ commits behind. The PR also includes a stray file (`answer_decimal.txt`) that looks like it wasn't meant to be committed. Recommend closing as already addressed on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the misleading documentation in this issue. The
fn_mutate_inplaceexample comment was incorrect - Pandera doesn't actually raise an error due to a limitation with@check typesand in-place Data Frame modifications.What I changed: