Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
- Coverage 83.76% 83.68% -0.09%
==========================================
Files 137 137
Lines 10764 10836 +72
==========================================
+ Hits 9017 9068 +51
- Misses 1747 1768 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
deepyaman
force-pushed
the
feat/ibis/lazy-wide-table-check-exec
branch
from
January 26, 2026 15:32
0ba67d7 to
0adff88
Compare
- Modified IbisCheckBackend.apply() to accept optional wide_table and check_index parameters for lazy evaluation mode - Split apply() into _apply_wide_table() and _apply_original() to maintain backwards compatibility with direct check calls - Added _extract_check_results() method to IbisSchemaBackend for extracting individual CoreCheckResult objects from the executed wide table - Rewrote DataFrameSchemaBackend.run_checks() to build a wide table through each check's apply() method, execute once, then extract results This enables accurate row-level failure correlation by ensuring all check results share the same base Ibis table object and are executed in a single query. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Convert failure rows to dict records format before reshaping, so each failing row becomes a single failure case (a dict of column values) rather than having each cell become a separate failure case. This matches the original run_check behavior and ensures n_failure_cases correctly limits the number of failure cases reported. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/ibis/lazy-wide-table-check-exec
branch
from
February 26, 2026 14:53
0adff88 to
91cdf34
Compare
Collaborator
|
Maintainer triage: the lazy wide-table check execution idea for Ibis is a reasonable perf improvement, but the Ibis backend has been substantially restructured since this was opened (188+ commits behind) as part of the ongoing Narwhals-backend unification. Rather than rebasing this specific implementation, it'd be worth re-evaluating whether the same optimization is still needed/applicable on top of the current narwhals-based Ibis path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.