-
Notifications
You must be signed in to change notification settings - Fork 4
Add org API client #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add org API client #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ugh, servant-client reaaaaally doesn't work so well with nested APIs like this. I got something half-decent, but manually re-wrapping all the endpoints is pretty annoying.
cp/add-org-clientintounisonImplementation notes
FromJSONandToJSONinstances to support the Client side of the equationTest coverage
Loose ends
I had to manually split off just the org api as its own thing; getting the entire API working as a valid client is largely untenable, there are responses which can't/shouldn't be deserialized back into their source (e.g. some namespace diff types lose information as part of serialization, maybe we shouldn't do that).