Skip to content

Conversation

@ChrisPenner
Copy link
Member

@ChrisPenner ChrisPenner commented Dec 4, 2024

Overview

This change causes Share to compute diffs for Contributions in-advance using a background queue that gets populated on relevant branch updates or contribution creations.

It then returns the full diff as part of the contribution diff endpoint, see transcripts for more info 👀

Implementation notes

  • Adds a new background job and associated PG queue table.
  • Adds a table where we store the cached diffs. The diffs are based on namespace hashes, so won't ever go stale
  • Adds the output to the contribution diff endpoint.

Test coverage

See transcripts

@ChrisPenner ChrisPenner marked this pull request as ready for review December 13, 2024 20:05
@ChrisPenner ChrisPenner requested a review from hojberg December 13, 2024 20:05
@ChrisPenner ChrisPenner merged commit 224fef8 into main Dec 13, 2024
8 checks passed
@ChrisPenner ChrisPenner deleted the cp/batched-diffs branch December 13, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants