Skip to content

Conversation

@ChrisPenner
Copy link
Member

@ChrisPenner ChrisPenner commented Dec 4, 2024

TODO:

  • Plan for future compatibility as best we can (leave gaps in UCM side so we can include additional metadata without erroring)
  • Figure out plans for how UCM can tell Share to omit subtrees/causals
  • Maybe mark certain causals as being part of the top-level spine?
  • Consider what else is necessary for making this work with push as well.
  • More testing with storing dependency depth in the DB and using that for sorting things.

Choose your PR title well: Your pull request title is what's used to create release notes, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.

Overview

What does this change accomplish and why? i.e. How does it change the user experience?

Feel free to include "before and after" examples if appropriate. (You can copy/paste screenshots directly into this editor.)

If relevant, which Github issues does it close? (See closing-issues-using-keywords.)

Implementation notes

How does it accomplish it, in broad strokes? i.e. How does it change the Haskell codebase?

Interesting/controversial decisions

Include anything that you thought twice about, debated, chose arbitrarily, etc.
What could have been done differently, but wasn't? And why?

Test coverage

Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?

Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?

Loose ends

Link to related issues that address things you didn't get to. Stuff you encountered on the way and decided not to include in this PR.

@ChrisPenner ChrisPenner force-pushed the syncv2/experiments branch 3 times, most recently from 00a62cb to a14b424 Compare December 17, 2024 18:47
@ChrisPenner ChrisPenner merged commit 7938f89 into main Jan 31, 2025
3 of 4 checks passed
@ChrisPenner ChrisPenner deleted the syncv2/experiments branch January 31, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants