-
Notifications
You must be signed in to change notification settings - Fork 972
Bugfix: Recommend pytorch-lightning>=2.5.3
for Google Colab notebook
#2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes unit8co#2670. Some versions of `pytorch-lightning` may not be comptaible with `torch_vla>=2.7.0` anymore due to deprecation of XLA APIs since 2.7. This was fixed in [Lightning 2.5.3](https://github.com/Lightning-AI/pytorch-lightning/releases/tag/2.5.3). See Lightning's [#20852](Lightning-AI/pytorch-lightning#20852) for the upstream bug fix. However, running the "21-TSMixer-examples", the notebook never got past "Model Training". Using the latest nightly build XLA 2.9.0 fixes the issue, as instructed on [pytorch/xla](https://github.com/pytorch/xla). The exact reasons why that is are unknown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigation and the the suggested solution @daidahao 🚀 Very nice to see!
As you mentioned, we currently fix pytorch lightning <= 2.5.3 because there was an issue with the lr_find()
method that didn't give the same learning rate suggestion as in earlier versions.
I have not yet had the time to raise this issue on their GitHub but will do so soon.
With your update, users wouldn't be able to install the current darts
package because pypi would complain about incompatible versions. Or did this work for you / could you test it?
Regardless, as soon as we would relax the lightning cap, and if your suggestion is ested then we can merge this PR :)
Hi Dennis, I have tested installing the latest darts and "pytorch-lightning>=2.5.3" at the same time on Colab. As you could see in this example 21-TSMixer-examples.ipynb, the requirement from darts 0.37.1 could be overwritten and the This is not a perfect solution because of Lightning's new |
Thanks @daidahao . In that case I would suggest that we wait first until they released a stable version and then we can continue with this PR. Is that alright with you? |
Yes, that is very reasonable! In the meantime, we could point to this PR as a temporary fix if there is any issue with TPU being raised. |
@daidahao, yes sounds great :) In the meantime I should find some time to raise the lr_find issue to lightning. |
@daidahao, looks like Lightning-AI/pytorch-lightning#21171 will fix the issue :) I'll keep an eye on it and once everything is in place we can go ahead with this PR |
@dennisbader Thanks Dennis! |
Checklist before merging this PR:
Fixes #2670.
Summary
Some versions of
pytorch-lightning
may not be comptaible withtorch_vla>=2.7.0
anymore due to deprecation of XLA APIs since 2.7. This was fixed in Lightning 2.5.3. See Lightning's #20852 for the upstream bug fix.However, running the "21-TSMixer-examples", the notebook never got past "Model Training". Using the latest nightly build XLA 2.9.0 fixes the issue, as instructed on pytorch/xla. The exact reasons why that is are unknown.
Other Information
pytorch-lightning>=2.5.3
due to an issue withlr_find()
, see Devops/cap lightning #2872.