Storing and Plotting Additional QED-C Metrics#437
Open
Neerpatel125 wants to merge 67 commits intounitaryfoundation:mainfrom
Open
Storing and Plotting Additional QED-C Metrics#437Neerpatel125 wants to merge 67 commits intounitaryfoundation:mainfrom
Neerpatel125 wants to merge 67 commits intounitaryfoundation:mainfrom
Conversation
Added code comments.
Neerpatel125
commented
Jul 18, 2025
Comment on lines
+179
to
+181
| # Set backend information for plot titles. | ||
| provider_name = "qBraid" | ||
| device_name = "<unknown>" |
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to get the provider_name and device_name when polling.
Contributor
There was a problem hiding this comment.
Any clever ideas on how to do this, @cosenal ? My initial thought would be to change the arguments for the polling function, but this would require changes to all benchmarks and going forward as well. Maybe supporting some type of *kwargs for polling here is a reasonable approach?
Contributor
There was a problem hiding this comment.
As we discussed on Friday, this is likely something outside of scope for this MR but something that we should perhaps spin up a separate issue about as this is likely a use-case that will crop up again (@cosenal )
vprusso
reviewed
Jul 19, 2025
Co-authored-by: Vincent Russo <vincentrusso1@gmail.com>
Co-authored-by: Vincent Russo <vincentrusso1@gmail.com>
Co-authored-by: Vincent Russo <vincentrusso1@gmail.com>
Co-authored-by: Vincent Russo <vincentrusso1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on storing additional QED-C metrics (circuit depth, width, 2-Qubit gates, etc.) and plotting them. The files generated are stored in
__data/and__images/after polling.The execution time and circuit creation time plots have been excluded, and no additional dependencies were added. This will complete the implementation of the selected QED-C benchmarks.
Issue ticket number and link
N/A
Type of change
How Has This Been Tested?
Each QED-C benchmark was ran and plotted using the local
aer_simulator. To reproduce results, run the example schema files for each benchmark -- they will display extra metrics and associated plots. No configuration changes need to be made for testing purposes.Checklist: