Configure http->https redirect only if apache2/force_https isn't enabled#3
Open
palstek wants to merge 1 commit intounivention:mainfrom
Open
Configure http->https redirect only if apache2/force_https isn't enabled#3palstek wants to merge 1 commit intounivention:mainfrom
palstek wants to merge 1 commit intounivention:mainfrom
Conversation
Otherwise use the global redirect, which will properly exclude .well-known/acme-challenge subdirectory for Letsencrypt. Otherwise Letsencrypt certificate refresh fails for ucs-sso-ng subdomain, because .well-known isn't accessible via plain http. This change feels more appropriate to me, than excluding .well-known from permanent redirect in this config file. Signed-off-by: Daniel Krueger <palstek@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise use the global redirect, which will properly exclude .well-known/acme-challenge subdirectory for Letsencrypt. Otherwise Letsencrypt certificate refresh fails for ucs-sso-ng subdomain, because .well-known isn't accessible via plain http.
This change feels more appropriate to me, than excluding .well-known from permanent redirect in this config file.