Elm: roles:imported -> roles:exposed for non-modules #3321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An imported modules still has roles:imported, but the items it brings in are listed as roles:exposed.
Codecov Report
@@ Coverage Diff @@
## master #3321 +/- ##
==========================================
- Coverage 85.41% 85.41% -0.01%
==========================================
Files 216 216
Lines 50278 50279 +1
==========================================
Hits 42947 42947
- Misses 7331 7332 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An imported modules still have
roles:imported, but the items it brings in are listed asroles:exposed.This has been discussed in #PR3312 and issue #3319.
Strictly speaking this is a breaking change, as you will see Units/parser-elm.r/elm-optlist-compatibility.d/expected.tags has had to change. However I believe it doesn't actually break anything. The original optlib parser was designed to work with Vim tagbar. Neither that, nor the specific configuration referenced roles. Therefore I think this is safe to include.
However, if you think it is better to reject this pull request to preserve backwards compatiblity that's okay. Saying a function or a type is "imported" (which is what happens without this change) is still okay.
Edited for clarity