Fixed recursive wrapping of data function that leads to memory leak (asyncData plugin).#66
Open
mr-luke wants to merge 1 commit intouniversal-vue:devfrom
Open
Fixed recursive wrapping of data function that leads to memory leak (asyncData plugin).#66mr-luke wants to merge 1 commit intouniversal-vue:devfrom
mr-luke wants to merge 1 commit intouniversal-vue:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixed memory leak of
asyncDataplugin.What is the current behavior?
There's a recursive wrapping of
datafunction which adds a new level each time SSR renders same component. This leads up to stuck references of asyncData variable that cannot be collected by GC.What is the new behavior?
Under first attempt the original
datafunction is cloned to internal options' property to ensure that each wrapping works on correct function.Checklist: