Fix the error when signatures from different set of shares or different messages are sent in parallel#13
Open
narcis2007 wants to merge 2 commits intouniwire:masterfrom
Open
Fix the error when signatures from different set of shares or different messages are sent in parallel#13narcis2007 wants to merge 2 commits intouniwire:masterfrom
narcis2007 wants to merge 2 commits intouniwire:masterfrom
Conversation
HRezaei
reviewed
Jan 22, 2024
| threshold: params[0].to_string(), | ||
| parties: params[1].to_string(), | ||
| x: y_sum.x_coor().unwrap().to_str_radix(10), | ||
| y: y_sum.x_coor().unwrap().to_str_radix(10), |
Contributor
There was a problem hiding this comment.
This should be y_coor(), shouldn't it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we can request different signatures from different set of shares in parallel without errors, it will just wait until the threshold for them is reached before proceeding instead of failing