Skip to content

test non-ui change #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test non-ui change #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16e642e
Add -DskipUI for most tests
rschlussel Jun 12, 2025
ee82a80
Skip UI tests when no ui change
unidevel Jul 11, 2025
e15f182
ui change
unidevel Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ env:
CONTINUOUS_INTEGRATION: true
MAVEN_OPTS: "-Xmx1024M -XX:+ExitOnOutOfMemoryError"
MAVEN_INSTALL_OPTS: "-Xmx2G -XX:+ExitOnOutOfMemoryError"
MAVEN_FAST_INSTALL: "-B -V --quiet -T 1C -DskipTests -Dair.check.skip-all --no-transfer-progress -Dmaven.javadoc.skip=true"
MAVEN_TEST: "-B -Dair.check.skip-all -Dmaven.javadoc.skip=true -DLogTestDurationListener.enabled=true --no-transfer-progress --fail-at-end"
MAVEN_FAST_INSTALL: "-B -V --quiet -T 1C -DskipTests -Dair.check.skip-all --no-transfer-progress -Dmaven.javadoc.skip=true -DskipUI"
MAVEN_TEST: "-B -Dair.check.skip-all -Dmaven.javadoc.skip=true -DLogTestDurationListener.enabled=true --no-transfer-progress --fail-at-end -DskipUI"
RETRY: .github/bin/retry

jobs:
Expand All @@ -21,6 +21,7 @@ jobs:
# Set job outputs to values from filter step
outputs:
codechange: ${{ steps.filter.outputs.codechange }}
uichange: ${{ steps.filter.outputs.uichange }}
steps:
# For pull requests it's not necessary to checkout the code
- uses: dorny/paths-filter@v2
Expand All @@ -29,6 +30,12 @@ jobs:
filters: |
codechange:
- '!presto-docs/**'
- uses: dorny/paths-filter@v2
id: ui_filter
with:
filters: |
uichange:
- 'presto-ui/**'

test:
runs-on: ubuntu-latest
Expand All @@ -46,7 +53,7 @@ jobs:
- ":presto-tests -P ci-only-distributed-queries"
- ":presto-tests -P ci-only-aggregation-queries"
- ":presto-tests -P ci-only-plan-determinism"
- ":presto-tests -P ci-only-resource-manager"
- ":presto-tests -P ci-only-resource-manager"
- ":presto-accumulo"
- ":presto-cassandra -P test-cassandra-integration-smoke-test"
- ":presto-hive"
Expand Down Expand Up @@ -89,8 +96,19 @@ jobs:
- name: Maven Install
if: needs.changes.outputs.codechange == 'true'
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
if [ "${{ needs.changes.outputs.uichange }}" != "true" ]; then
EXTRA_ARGS="-DskipUI"
else
EXTRA_ARGS=""
fi
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS} ${EXTRA_ARGS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl $(echo '${{ matrix.modules }}' | cut -d' ' -f1)
- name: Maven Tests
if: needs.changes.outputs.codechange == 'true'
run: ./mvnw test ${MAVEN_TEST} -pl ${{ matrix.modules }}
run: |
if [ "${{ needs.changes.outputs.uichange }}" != "true" ]; then
EXTRA_ARGS="-DskipUI"
else
EXTRA_ARGS=""
fi
./mvnw test ${MAVEN_TEST} ${EXTRA_ARGS} -pl ${{ matrix.modules }}
2 changes: 2 additions & 0 deletions presto-ui/src/plan.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import lazy from "./lazy";
import {PageTitle} from "./components/PageTitle";
import {getFirstParameter} from "./utils";



const LivePlan = lazy('LivePlan');

ReactDOM.render(
Expand Down
Loading