Skip to content

Check alternate chains prior to default chain when providing force_chain #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check alternate chains prior to default chain when providing force_chain #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/acme/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,17 +156,17 @@ def certificate(url:, force_chain: nil)

return pem if force_chain.nil?

return pem if ChainIdentifier.new(pem).match_name?(force_chain)

alternative_urls = Array(response.headers.dig('link', 'alternate'))
alternative_urls.each do |alternate_url|
response = download(alternate_url, format: :pem)
pem = response.body
if ChainIdentifier.new(pem).match_name?(force_chain)
return pem
alternate_pem = response.body
if ChainIdentifier.new(alternate_pem).match_name?(force_chain)
return alternate_pem
end
end

return pem if ChainIdentifier.new(pem).match_name?(force_chain)

raise Acme::Client::Error::ForcedChainNotFound, "Could not find any matching chain for `#{force_chain}`"
end

Expand Down