feat: add .catch to command declaration#113
Closed
ItsMeBrianD wants to merge 3 commits intounjs:mainfrom
Closed
Conversation
Author
|
@pi0 any idea when this can get looked at? |
Member
|
Thanks for the PR. Honestly im not sure about catch to be best naming idea and i need to think about that |
Author
|
@pi0 any updates here? |
Author
|
@pi0 just want to check and see if there is anything I can do to get this across the line |
Author
|
@pi0 would really like to get this merged so we can use mainline |
Member
|
Sorry for all delay, moving to #185 since couldn't push to your fork branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #112
❓ Type of change
📚 Description
This adds an additional function
.catchto a command definition. It works similarly to setup and cleanup, but the error does not bubble all the way up if caught.This allows for custom error handling that may differ from the default (e.g. changing the console output of a CLI when an uncaught exception occurs anywhere in the app).
Example usage of catch:
📝 Checklist
[ ] I have updated the documentation accordingly.There doesn't seem to be a place in the documentation to update, but I did write tests with full coverage