fix(fontless): emitFile during transform#653
Draft
Conversation
❌ Deploy Preview for fontless failed.
|
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 53.40% 52.90% -0.50%
==========================================
Files 11 11
Lines 734 739 +5
Branches 93 93
==========================================
- Hits 392 391 -1
- Misses 342 348 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
When using "shared plugin mode" during build https://vite.dev/guide/api-environment-plugins.html#shared-plugins-during-build, plugin's
assetContext.renderedFontURLsstate is shared between all environment builds and it causesemitFileduringgenerateBundleto doubly/triply output font assets on unrelated environments. For example, this is the case on@vitejs/plugin-rscbased app and it currently causes css and font processed onrscenvironment to cause other environments to also write font files.solution
This PR moves
emitFilefromgenerateBundletoassetContext.callback, which is called only whentransformCssfound a relevant assets and this avoids generating fonts in an unrelated environment.