feat: support copying from local file protocol#228
Open
feat: support copying from local file protocol#228
Conversation
Author
|
@pi0 |
pi0
reviewed
Sep 9, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 54.63% 48.52% -6.11%
==========================================
Files 7 6 -1
Lines 615 577 -38
Branches 47 62 +15
==========================================
- Hits 336 280 -56
- Misses 278 297 +19
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #109
Support for the
fileprotocol has been added.file:///path/to/dir~) expansion is also supported. However, since the standardfile://format typically only supports absolute paths, a custom formatfile:~/is used to enable this feature.Since the
fileprotocol involves copying a directory rather than extracting a tarball, the processing logic and handling of options differ significantly from those indownloadTemplate. For this reason, we’ve separated the responsibilities and implemented it as a separate function.If you believe it would be better to handle the
fileprotocol as a branch withindownloadTemplate, we’re happy to revise the implementation accordingly. We would appreciate your feedback.