Draft
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @danielroe on Vercel. @danielroe first needs to authorize it. |
|
Collaborator
|
I think we could make this as a creating input helper similar to some thoughts: we could extends the original export const charIn = <T extends string,From extends string, To extends string, Sets extends [from: From,to:To][]>(chars: T,...sets: Sets) =>
createInput(`[${chars.replace(/[-\\^\]]/g, '\\$&')}${sets.map(set=>`${set[0]}-${set[1]}`).join()}]`) as Input<`[${EscapeChar<T>}${Join<{[k in keyof Sets]: `${Sets[k][0]}-${Sets[k][1]}`},'',''>}]`>if we do so, we should also update then maybe add some helper functions for convenience: export const charSet = <From extends string,To extends string>(from: From, to: To) =>
charIn('',[from,to])
export const charSets = <From extends string, To extends string, Sets extends [from: From,to: To][]>(...sets:Sets) =>
charIn('',...sets)just some ideas, still need to make sure naming is intuitive. And maybe use function overloading if needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to implement the
betweenmethod.If you have any suggestions it would be great to hear. @danielroe
Actually, it works now, but I was not able to import
betweendirectly. So I had to chain after "exactly".