build: explicitly mark fns to improve tree-shaking#130
Closed
Conversation
1 task
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #129
(This PR is mainly for experimenting)
Add explicit
/* @__PURE__ */marks to improve tree-shaking with a roll-up. (it does not fully trustsideEffects: falseinpackage.jsononly)This only works if the rollup
treeshakeoption is set tosmallestand by default does not change any behavior still!Due to ESBuild limitations for minify options, we have to disable whitespace modification which means the default size of
dist/index.mjsgoes from3.96 kBto4.86 kB.rollup repl