Skip to content

fix: handle font-stretch returned by font providers #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florian-lefebvre wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: handle font-stretch returned by font providers #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fefa69f
fix: handle font-stretch returned by font providers
florian-lefebvre Mar 13, 2026
9694334
fix: test
florian-lefebvre Mar 13, 2026
37352f1
fix: test
florian-lefebvre Mar 13, 2026
81bd3d1
Apply suggestions from code review
florian-lefebvre Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/css/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const extractableKeyMap: Record<string, keyof FontFaceData> = {
'src': 'src',
'font-display': 'display',
'font-weight': 'weight',
'font-stretch': 'stretch',
'font-style': 'style',
'font-feature-settings': 'featureSettings',
'font-variation-settings': 'variationSettings',
Expand Down Expand Up @@ -130,6 +131,10 @@ function extractCSSValue(node: Declaration) {
if (child.type === 'Number') {
values.push(Number(child.value))
}
if (child.type === 'Percentage') {
const percentageValue = `${child.value}%`
buffer = buffer ? `${buffer} ${percentageValue}` : percentageValue
}
}

if (buffer) {
Expand Down
24 changes: 24 additions & 0 deletions test/extract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,30 @@ describe('css font-face extraction', () => {
`)
})

it('should handle percentages', () => {
const css = `
@font-face {
font-family: 'Test Font';
src: url('/test.woff2') format('woff2');
font-stretch: 110%;
}
`

expect(extractFontFaceData(css)).toMatchInlineSnapshot(`
[
{
"src": [
{
"format": "woff2",
"url": "/test.woff2",
},
],
"stretch": "110%",
},
]
`)
})

it('should handle multi-value font-style properties', () => {
expect(extractFontFaceData(`
@font-face {
Expand Down
2 changes: 2 additions & 0 deletions test/providers/adobe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ describe('adobe', () => {
"url": "https://use.typekit.net/font",
},
],
"stretch": "normal",
"style": "italic",
"weight": 400,
},
Expand All @@ -95,6 +96,7 @@ describe('adobe', () => {
"url": "https://use.typekit.net/font",
},
],
"stretch": "normal",
"style": "normal",
"weight": 400,
},
Expand Down
Loading