Skip to content

feat: add optional error skipping for getKeys()#617

Open
kricsleo wants to merge 2 commits intounjs:mainfrom
kricsleo:feat/keys-optional-error
Open

feat: add optional error skipping for getKeys()#617
kricsleo wants to merge 2 commits intounjs:mainfrom
kricsleo:feat/keys-optional-error

Conversation

@kricsleo
Copy link
Member

@kricsleo kricsleo commented Apr 11, 2025

resolves #208

try: true or throw: false - which is better? 🤔

@kricsleo kricsleo requested a review from pi0 as a code owner April 11, 2025 14:04
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.13%. Comparing base (70310f9) to head (4021926).
⚠️ Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   59.99%   60.13%   +0.13%     
==========================================
  Files          42       42              
  Lines        3657     3760     +103     
  Branches      590      611      +21     
==========================================
+ Hits         2194     2261      +67     
- Misses       1460     1496      +36     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow getKeys to optionally skip errors

1 participant