Skip to content

Commit 7888456

Browse files
committed
fix: use failure status for approval-blocked GitHub deployments
Show a red failed check on the PR instead of a yellow pending dot when a deployment requires authorization. Clicking the check links to the dashboard approval page.
1 parent 33dd025 commit 7888456

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

svc/ctrl/worker/githubwebhook/handle_push.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,12 @@ func (s *Service) HandlePush(ctx restate.ObjectContext, req *hydrav1.HandlePushR
227227
repo.InstallationID,
228228
req.GetRepositoryFullName(),
229229
ghDeploymentID,
230-
"pending",
230+
"failure",
231231
"",
232232
logURL,
233233
"Awaiting authorization from a project member",
234234
)
235-
}, restate.WithName("github deployment status: pending"), restate.WithMaxRetryDuration(30*time.Second))
235+
}, restate.WithName("github deployment status: failure (awaiting auth)"), restate.WithMaxRetryDuration(30*time.Second))
236236
}
237237

238238
continue

0 commit comments

Comments
 (0)