Skip to content

Comments

feat: dns compatible sentinel ids#5084

Draft
chronark wants to merge 12 commits intomainfrom
dns-compatible-sentinel-ids
Draft

feat: dns compatible sentinel ids#5084
chronark wants to merge 12 commits intomainfrom
dns-compatible-sentinel-ids

Conversation

@chronark
Copy link
Collaborator

@chronark chronark commented Feb 19, 2026

use sentinel ids as k8s names so we don't have to look them up every time

main changes:

  • make uid.New always create (mostly) dns-safe ids
  • add converter methods to translate from prefix_xxx to prefix-xxx and back
  • hook up the sentinel logic to use these instead of k8s_name

@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Feb 19, 2026 11:28am
engineering Ready Ready Preview, Comment Feb 19, 2026 11:28am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dns-compatible-sentinel-ids

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant