Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis pull request refactors how deployment data flows through the deployment view layer. Components previously extracted Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
What does this PR do?
We had a hook called
useDeploymentwhere we readdeploymentIdfrom params, but we can actually call ouruseProjectsDatahooks methodgetDeploymentByIdand return the actual deployment instead of justdeploymentId. This will ensure that we manage the deployment data from single source of truthHow should this be tested?