1812 migrate alert component to wdn6.0 version 2#1814
Open
sarongebre wants to merge 7 commits into6.0from
Open
1812 migrate alert component to wdn6.0 version 2#1814sarongebre wants to merge 7 commits into6.0from
sarongebre wants to merge 7 commits into6.0from
Conversation
… plain JavaScript. Fixes #1812.
… on CMS), I’ve removed the logic that sets the unlAlertsData cookie, as it interferes with how WDN5 handles it. I’ll work on new logic for storing alert data in the cookie, which will be deployed once all sites have migrated to WDN6.
… JavaScript needs to be loaded. Two new cookie names were created to prevent conflicts with existing WDN5 alert cookies, as some sites will remain on WDN5 for a while until they migrate. Fixes 1812.
…igrate-alert-component-to-wdn6.0-version-2
|
tommyneu
requested changes
Aug 12, 2025
| ); | ||
| } | ||
|
|
||
| async #checkIfFetchCallNeeded() { |
Member
There was a problem hiding this comment.
If I have two tabs open and if there is no data in unlcap.js then both tabs will be fetching the data. If there is data in unlcap.js then it preforms as intended. This is leading to unneeded requests for unlcap.js. If there is no data in unlcap.js then the cookie needs to still be set so that these unneeded requests are not being sent
tommyneu
requested changes
Aug 13, 2025
Member
tommyneu
left a comment
tommyneu
left a comment
There was a problem hiding this comment.
Making sure to write this down, the ID unlalert is being used in multiple elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated alert component to wdn framework 6. Replaced all jQuery with plain JavaScript. Fixed alert close icon showing after refresh.
Version 2 contains: Saving alert data to a cookie to reduce the number of times the alert JavaScript needs to be loaded. Two new cookie names were created to prevent conflicts with existing WDN5 alert cookies, as some sites will remain on WDN5 for a while before migrating.
Closes #1812
Closes #1757