Refactor github to use ghfs by UnstoppableMango · Pull Request #151 · unmango/aferox

UnstoppableMango · 2026-03-21T16:43:45Z

Vibe
The old tests

codecov · 2026-03-21T16:45:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (ca36cc9) to head (176dd97).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files          26       26           
  Lines         680      680           
=======================================
  Hits          566      566           
  Misses        106      106           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Refactors the github submodule to delegate GitHub-backed filesystem behavior to the external github.com/unstoppablemango/ihfs/ghfs implementation, removing the in-repo GitHub path parsing and per-resource filesystem packages (user/repository/release/content/asset) and consolidating tests at the module level.

Changes:

Replaced the previous github filesystem stack (ghpath, user, repository, release, content, asset) with a thin wrapper around ihfs/ghfs.
Added an afero.File adapter (github.File) that wraps io/fs files returned by ghfs.
Consolidated/updated tests and updated github/go.mod + github/go.sum dependencies accordingly.

Reviewed changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
github/fs.go	Switches `Fs` to wrap `*ghfs.Fs` and adapts Open/Stat to the new backend.
github/file.go	Adds an `afero.File` adapter over `io/fs.File` with optional interface support.
github/github_suite_test.go	Moves shared test `client` init into the module-level suite.
github/fs_test.go	New consolidated filesystem tests targeting `ghfs`-style paths.
github/file_test.go	Updates file tests to use the new module-level `Fs` and paths; adds archive-dir test.
github/go.mod	Removes ghpath-related deps and adds `github.com/unstoppablemango/ihfs/ghfs`.
github/go.sum	Updates checksums to reflect removed/added dependencies.
github/user/user_suite_test.go	Removed (tests consolidated at module level).
github/user/fs.go	Removed (superseded by `ghfs`).
github/user/fs_test.go	Removed (tests consolidated at module level).
github/user/fileinfo.go	Removed (superseded by `ghfs`).
github/user/file.go	Removed (superseded by `ghfs`).
github/repository/repository_suite_test.go	Removed (tests consolidated at module level).
github/repository/fs.go	Removed (superseded by `ghfs`).
github/repository/fs_test.go	Removed (tests consolidated at module level).
github/repository/fileinfo.go	Removed (superseded by `ghfs`).
github/repository/file.go	Removed (superseded by `ghfs`).
github/repository/file_test.go	Removed (tests consolidated at module level).
github/repository/release/release_suite_test.go	Removed (tests consolidated at module level).
github/repository/release/fs.go	Removed (superseded by `ghfs`).
github/repository/release/fs_test.go	Removed (tests consolidated at module level).
github/repository/release/fileinfo.go	Removed (superseded by `ghfs`).
github/repository/release/file.go	Removed (superseded by `ghfs`).
github/repository/release/file_test.go	Removed (tests consolidated at module level).
github/repository/release/asset/asset_suite_test.go	Removed (tests consolidated at module level).
github/repository/release/asset/fs.go	Removed (superseded by `ghfs`).
github/repository/release/asset/fs_test.go	Removed (tests consolidated at module level).
github/repository/release/asset/fileinfo.go	Removed (superseded by `ghfs`).
github/repository/release/asset/file.go	Removed (superseded by `ghfs`).
github/repository/release/asset/file_test.go	Removed (tests consolidated at module level).
github/repository/content/content_suite_test.go	Removed (tests consolidated at module level).
github/repository/content/fs.go	Removed (superseded by `ghfs`).
github/repository/content/fs_test.go	Removed (tests consolidated at module level).
github/repository/content/fileinfo.go	Removed (superseded by `ghfs`).
github/repository/content/file.go	Removed (superseded by `ghfs`).
github/repository/content/directoryinfo.go	Removed (superseded by `ghfs`).
github/repository/content/directory.go	Removed (superseded by `ghfs`).
github/ghpath/path.go	Removed (path parsing delegated to `ghfs`).
github/ghpath/path_test.go	Removed (path parsing delegated to `ghfs`).
github/ghpath/ghpath_suite_test.go	Removed (tests consolidated at module level).
github/internal/context.go	Removed (no longer needed after refactor).
github/internal/constraint.go	Removed (no longer needed after refactor).

Comments suppressed due to low confidence (1)

github/file_test.go:22

These tests exercise ghx.NewFs(client) with a real internal.DefaultClient() and then call Open/Readdirnames, which will hit the live GitHub API but are not labeled E2E. To keep make test (which excludes E2E) reliable and offline-friendly, consider marking the network-dependent specs as E2E or using a mock HTTP transport/server.

Copilot · 2026-03-21T16:49:02Z

github/fs_test.go

+	It("should open user", func() {
+		fs := ghx.NewFs(client)
+
+		file, err := fs.Open("users/UnstoppableMango")
+
+		Expect(err).NotTo(HaveOccurred())
+		Expect(file.Name()).To(Equal("users/UnstoppableMango"))
+	})
+
+	It("should open user file", func() {
+		fs := ghx.NewFs(client)
+
+		file, err := fs.OpenFile("users/UnstoppableMango", 69, os.ModePerm)
+
+		Expect(err).NotTo(HaveOccurred())
+		Expect(file.Name()).To(Equal("users/UnstoppableMango"))
+	})
+
+	It("should stat user", func() {
+		fs := ghx.NewFs(client)
+
+		info, err := fs.Stat("users/UnstoppableMango")
+
+		Expect(err).NotTo(HaveOccurred())
+		Expect(info.Name()).To(Equal("UnstoppableMango"))
+	})


These specs appear to make live GitHub API calls via client = internal.DefaultClient() (http.DefaultClient + optional GITHUB_TOKEN) but are not labeled E2E. Per AGENTS.md, non-E2E runs typically exclude E2E tests, so these will still run in make test and may be flaky/offline-failing. Consider labeling the network-dependent cases as Label("E2E") (or switching to an httptest/mock client) so unit test runs remain deterministic.

Copilot · 2026-03-21T16:49:03Z

github/file.go

+// ReadAt implements afero.File.
+func (f *File) ReadAt(p []byte, off int64) (int, error) {
+	if ra, ok := f.file.(io.ReaderAt); ok {
+		return ra.ReadAt(p, off)
+	}
+	return 0, errors.ErrUnsupported
+}
+
+// Readdir implements afero.File.
+func (f *File) Readdir(count int) ([]fs.FileInfo, error) {
+	rd, ok := f.file.(fs.ReadDirFile)
+	if !ok {
+		return nil, errors.ErrUnsupported
+	}


ReadAt, Readdir*, and Seek return errors.ErrUnsupported when the wrapped fs.File doesn’t implement the corresponding optional interfaces. Elsewhere in this repo similar “unsupported” filesystem/file operations typically return syscall-style errors (e.g., syscall.EPERM/syscall.EROFS; see github/internal/readonly.go and writer/file.go). Returning a different sentinel error can be a breaking behavioral change for callers/tests that expect POSIX errors. Consider mapping these cases to the appropriate syscall errors for consistency (e.g., EPERM for seek/readat, ENOTDIR for readdir on non-directories, etc.).

UnstoppableMango added 2 commits March 15, 2026 22:21

Vibe

430ebf4

The old tests

176dd97

Copilot AI review requested due to automatic review settings March 21, 2026 16:43

Copilot started reviewing on behalf of UnstoppableMango March 21, 2026 16:44 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor github to use ghfs#151

Refactor github to use ghfs#151
UnstoppableMango wants to merge 2 commits intomainfrom
ghfs

UnstoppableMango commented Mar 21, 2026

Uh oh!

codecov bot commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

UnstoppableMango commented Mar 21, 2026

Uh oh!

codecov bot commented Mar 21, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants