Skip to content

Correct BaseURL and Domain default values in docs#252

Open
catfromplan9 wants to merge 1 commit intounmojang:masterfrom
catfromplan9:documentation-fixes
Open

Correct BaseURL and Domain default values in docs#252
catfromplan9 wants to merge 1 commit intounmojang:masterfrom
catfromplan9:documentation-fixes

Conversation

@catfromplan9
Copy link
Contributor

BaseURL and Domain default to "", update documentation accordingly

Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these options are both mandatory, it would be better to leave it as-is but change "Default value" to "Example value", like how the [ImportExistingPlayer] options are documented.

@catfromplan9
Copy link
Contributor Author

Since these options are both mandatory, it would be better to leave it as-is but change "Default value" to "Example value", like how the [ImportExistingPlayer] options are documented.

This is already handled by recipes

@catfromplan9
Copy link
Contributor Author

Can we keep default value and example value?

@catfromplan9
Copy link
Contributor Author

Better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants