Fix: MonoRuntimeMixedModeExcludedAssembly ignored when WasmShellAOTProfileExcludedMethods unset (backport #1027)#1028
Merged
jeromelaban merged 11 commits intorelease/stable/10.0from Jan 29, 2026
Conversation
The issue was that MixedModeExcludedAssembly parameter was being passed as a property (string) instead of an item group (array). This prevented MonoRuntimeMixedModeExcludedAssembly from working independently. Also added a test project to validate the fix using WasmShellGenerateAOTProfileDebugList. Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 27a85f7)
Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 513d477)
Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 32926cc)
Added Uno.Wasm.Tests.MixedModeProfile to the netcore-only solution filter to ensure it's built and validated as part of continuous integration. Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 05a73a5)
Added dedicated build steps to both Linux and Windows CI pipelines that explicitly run 'dotnet publish' on the MixedModeProfile test project. This ensures the AOT process runs and the post-build validation target can verify that profile filtering works correctly. Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 2d292c6)
- Enhanced post-build validation to actually analyze profile content - Verifies Newtonsoft.Json methods exist in original profile - Verifies Newtonsoft.Json and System.Xml methods are excluded from filtered profile - Removed accidentally added nuget.exe binary - Updated README with detailed validation information Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 363111b)
The test project was added to the solution filter but not to the main .sln file, causing MSB5028 build error. Added the project entry with proper configuration mappings and nested it under the Tests folder. Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 70776c0)
- Removed MixedModeProfile from netcore-only.slnf to avoid memory issues - Changed validation target to run AfterTargets="Publish" instead of "Build" - Added condition to only run validation when WasmAotProfilePath is set - AOT profile processing happens during Publish, not Build phase Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit ddecc5f)
…tion - Updated Program.cs to actually use Newtonsoft.Json (SerializeObject/DeserializeObject) - Changed from WasmShellEnableAotProfile to WasmAotProfilePath property - This ensures Newtonsoft.Json methods are in the AOT profile so validation can verify they're filtered out Co-authored-by: jeromelaban <5839577+jeromelaban@users.noreply.github.com> (cherry picked from commit 2160d63)
(cherry picked from commit 13d995c)
(cherry picked from commit 70ece07)
14 tasks
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonoRuntimeMixedModeExcludedAssemblynot working when used alone@(MonoRuntimeMixedModeExcludedAssembly)instead of$(WasmShellMixedModeExcludedAssembly)WasmShellGenerateAOTProfileDebugListOriginal prompt
MonoRuntimeMixedModeExcludedAssemblyis not taken into account ifWasmShellAOTProfileExcludedMethodsis not specified #1026💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This is an automatic backport of pull request #1027 done by [Mergify](https://mergify.com).