Merged
Conversation
ajpinedam
force-pushed
the
dev/anpi/fix.check.iossdk
branch
from
9047369 to
cfe6e25
Compare
jeromelaban
approved these changes
Apr 10, 2025
spouliot
reviewed
Apr 16, 2025
|
|
||
| if (Directory.Exists(iphoneSimulatorSDKPath)) | ||
| { | ||
| return true; |
Contributor
There was a problem hiding this comment.
If you delete the iOS SDK (from Xcode Component's window) then the directory will still be present, so the check will pass but the SDK will be missing (at build time).
| return Task.FromResult(new DiagnosticResult( | ||
| Status.Error, | ||
| this, | ||
| new Suggestion("Run `open -a Xcode`", |
Contributor
There was a problem hiding this comment.
That suggestion will not work if copy/pasted into a terminal. IOW it won't start Xcode (no path) and, if fixed, it won't show the Component window where the SDK can be loaded.
We should implement the steps from https://developer.apple.com/documentation/xcode/downloading-and-installing-additional-xcode-components#Download-Xcode-components-from-the-command-line
so we download and install the SDK from uno-check
This was referenced Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #172
This pull request introduces a new validation step to ensure the iOS SDK is installed when examining the Xcode setup.
Validation Enhancement:
public override Task<DiagnosticResult> Examine(SharedState history)to validate the presence of the iOS SDK and provide instructions if it is missing.ValidateForiOSSDK(XCodeInfo selected)to encapsulate the logic for checking the iOS SDK installation.