Skip to content

feat: Add MediaPlayerElement as alias to MediaElement #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartinZikmund wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add MediaPlayerElement as alias to MediaElement #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Uno.Templates/content/unoapp/.template.config/TemplateWizard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"localization": "false",
"logging": "none",
"markup": "xaml",
"mediaElement": "false",
"mediaPlayerElement": "false",
"navigation": "blank",
"platforms": "android|ios|wasm|desktop",
"rider": "true",
Expand Down Expand Up @@ -132,7 +132,7 @@
"localization": "true",
"logging": "default",
"markup": "xaml",
"mediaElement": "false",
"mediaPlayerElement": "false",
"navigation": "regions",
"platforms": "android|ios|wasm|desktop",
"rider": "true",
Expand Down Expand Up @@ -231,7 +231,7 @@
// and we recently removed .NET 8 option from the template (see PR #1373).
// This feature will be re-enabled once multi-threading becomes available again.
//"SymbolIds": [ "toolkit", "mauiEmbedding", "server", "wasmMultiThreading", "wasmPwaManifest", "vscode", "enableDeveloperMode", "mediaElement" ]
"SymbolIds": [ "toolkit", "mauiEmbedding", "server", "wasmPwaManifest", "vscode", "enableDeveloperMode", "mediaElement" ]
"SymbolIds": [ "toolkit", "mauiEmbedding", "server", "wasmPwaManifest", "vscode", "enableDeveloperMode", "mediaPlayerElement" ]
}
,
{
Expand Down Expand Up @@ -681,7 +681,7 @@
"vscode": {
"Icon": "/Assets/Features.VSCode.svg"
},
"mediaElement": {
"mediaPlayerElement": {
"Icon": "/Assets/Features.MediaElement.svg"
},
"wasmPwaManifest": {
Expand Down Expand Up @@ -777,7 +777,7 @@
"themeService",
"continuousIntegration",
"isCustomized",
"mediaElement",
"mediaPlayerElement",
"renderer"
],
"PackagesToUpdate": [
Expand Down
4 changes: 4 additions & 0 deletions src/Uno.Templates/content/unoapp/.template.config/dotnetcli.host.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@
},
"mediaElement": {
"longName": "media-element",
"shortName": "mediaelement"
},
"mediaPlayerElement": {
"longName": "media-player-element",
"shortName": "media"
},
"skipRestore": {
Expand Down
14 changes: 13 additions & 1 deletion src/Uno.Templates/content/unoapp/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,14 @@
// },
"mediaElement": {
"displayName": "Media Element",
"description": "Configures application to bundle native assets required for the MediaElement",
"description": "Configures application to bundle native assets required for the MediaPlayerElement",
"type": "parameter",
"datatype": "bool",
"defaultValue": "false"
},
"mediaPlayerElement": {
"displayName": "Media Player Element",
"description": "Configures application to bundle native assets required for the MediaPlayerElement",
"type": "parameter",
"datatype": "bool",
"defaultValue": "false"
Expand Down Expand Up @@ -937,6 +944,11 @@
"datatype": "bool",
"value": "(unoLottie || (useToolkit && appThemeEvaluator == 'fluent'))"
},
"useMediaPlayerElement": {
"type": "computed",
"datatype": "bool",
"value": "(mediaElement || mediaPlayerElement)"
},
"themeBackgroundBrush": {
"type": "generated",
"generator": "switch",
Expand Down
4 changes: 2 additions & 2 deletions src/Uno.Templates/content/unoapp/MyExtensionsApp.1/MyExtensionsApp.1.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
<!--#if (useUnoLottie)-->
Lottie;
<!--#endif-->
<!--#if (mediaElement)-->
MediaElement;
<!--#if (useMediaPlayerElement)-->
MediaPlayerElement;
<!--#endif-->
<!--#if (unoSvg)-->
Svg;
Expand Down
Loading