Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a temporary workaround comment from the launch settings template that referenced a resolved issue. The change removes guidance that instructed users to comment out the Packaged profile when using Mobile targets, as the underlying WinAppSDK debugging issue has been fixed.
- Removes outdated comment block referencing a resolved GitHub issue
- Cleans up conditional compilation directives for Mobile target scenarios
kazo0
approved these changes
Jul 24, 2025
| //#if (useWinAppSdk) | ||
| //#if (!useMsalAuthentication) | ||
| //#if (useMobile) | ||
| // Note: In order to select this profile, you'll need to comment the `Packaged` profile below until this is fixed: https://aka.platform.uno/wasdk-maui-debug-profile-issue |
Contributor
There was a problem hiding this comment.
Just want to double check and confirm with @jeromelaban that this comment is indeed no longer needed
Member
There was a problem hiding this comment.
I believe it is, but it has a tendency to come back after a few versions :) This is not the first time it got fixed on VS's side.
Member
|
The referenced issue is still fixed in latest VS2026, let's merge. |
jeromelaban
force-pushed
the
chore/remove-solved-issue-comment
branch
from
31309ee to
7323cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
if the user includes the Mobile target, he will get this comment added in his template, advising to uncomment/comment out the Packaged WinAppSdk target, but this seems (following this link) to be fixed 🎉 lets remove this? 🙃
What is the new behavior?
lets remove this? 🙃
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
While this particular issue is fixed, could the team quick check if there are other issues open (Backlog I think you call it?) that would still require us users to do anything on this profile and we might should have a comment to this there, but with some link update?
Internal Issue (If applicable):