Skip to content

Conversation

MartinZikmund
Copy link
Member

GitHub Issue: closes #4579

PR Type: 🐞 Bugfix

What is the current behavior? πŸ€”

What is the new behavior? πŸš€

PR Checklist βœ…

Please check if your PR fulfills the following requirements:

Other information ℹ️

@Copilot Copilot AI review requested due to automatic review settings July 17, 2025 11:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing fallback support for the "Segoe UI Symbol" font in FontFamily and introduces a unit test to verify symbol font fallback behavior.

  • Extend the font fallback condition in FontFamily to include "Segoe UI Symbol"
  • Refactor unit tests: narrow the WASM guard and add a new Symbol_Fonts_Fallback test

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Uno.UI/UI/Xaml/FontFamily.cs Added a Contains("Segoe UI Symbol") check alongside existing symbol font conditions
src/Uno.UI.RuntimeTests/.../Given_FontFamily.cs Updated test scaffold: wrapped only the pure-name test in #if __WASM__, added a fallback test
Comments suppressed due to low confidence (2)

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media/Given_FontFamily.cs:61

  • Add additional test cases where the family name contains the symbol font as part of a path or file name (e.g., "fonts/Segoe UI Symbol.ttf") to ensure the Contains logic correctly triggers fallback in non-exact-match scenarios.
			fontFamily = new FontFamily("Segoe UI Symbol");

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media/Given_FontFamily.cs:57

  • [nitpick] Consider renaming this test to something more descriptive, e.g. Fallback_When_FontFamilyIsSymbolFont, to clearly convey the scenario being validated.
		public void Symbol_Fonts_Fallback()

@unodevops
Copy link
Contributor

πŸ€– Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21070/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

πŸ€– Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21070/docs/index.html

1 similar comment
@unodevops
Copy link
Contributor

πŸ€– Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21070/docs/index.html

@unodevops
Copy link
Contributor

πŸ€– Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21070/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

πŸ€– Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21070/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

πŸ€– Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21070/docs/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 171372 has failed on Uno.UI - CI.

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jul 22, 2025
@MartinZikmund MartinZikmund enabled auto-merge July 22, 2025 13:04
@unodevops
Copy link
Contributor

πŸ€– Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21070/docs/index.html

@unodevops
Copy link
Contributor

πŸ€– Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21070/wasm-skia-net9/index.html

@MartinZikmund MartinZikmund disabled auto-merge July 22, 2025 13:50
@MartinZikmund MartinZikmund marked this pull request as draft July 22, 2025 13:50
@MartinZikmund
Copy link
Member Author

MartinZikmund commented Jul 22, 2025

Keeping open until new text rendering changes are merged, after which it will need to be adjusted

cc @ramezgerges

@unodevops
Copy link
Contributor

⚠️⚠️ The build 171476 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segoe UI Symbols/Segoe MDL2 Assets are not properly applied
4 participants